Re: [PATCH 0/4] plugging some mmap() leaks

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 7, 2026, 01:15 UTC
Message-ID: <xmqqms0kv3rn.fsf@gitster.g>
In-Reply-To: <c3ae9ff6-8577-48de-8473-9ec8d22ebc71@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 10 quoted lines

> If you look at the (currently 31) calls to munmap(), only one seems to look
> at the return (in refs/packed-backend.c:183). So, calling munmap() twice
> on the same memory region will probably go unnoticed when NO_MMAP is not
> set. I have no idea why munmap() was called twice on the same memory region,
> since I didn't track down the code responsible.
>
> It was just an FYI about a _potential_ lurking bug when using the mmap compat
> routines.
>
> Have I cleared that up, or confused you more. :)

Oh, absolutely.  Thanks.