Re: [PATCH 0/4] run auto maintenance in git-gui

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 7, 2026, 22:01 UTC
Message-ID: <xmqqms0jti24.fsf@gitster.g>
In-Reply-To: <e17f094f-f869-4cc9-b59c-091b7e61a021@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

Show 13 quoted lines

> However, the consequences for users need to be considered. You replace
> the custom implementation of `git gc` with `git maintenance run --auto`.
> The latter CAN do a lot more than the former. It turns out, that Git GUI
> already calls into `git maintance` indirectly via `git merge` and `git
> fetch`. So, users who set gui.gcwarning to false (myself included) were
> already prone to occasional inadvertent cleanups.
>
> So, users that are hurt by this new change are those where all these
> conditions are true:
> ...
> How many could this be? Not many, I guess. The conservative safe
> approach would be to treat gui.gcwarning=false as an indication that
> automatic cleanup is not desired.

Hmph, if you are _declining_ to see the warning, isn't it a sign that you are getting these warnings and got annoyed enough to find out about the settings and turned it to "false" to squelch? And if we make pruning more aggressive, wouldn't gui.gcwarning explicitly set to false be a sign that you'd be more likely to be in the affected poulation?