git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/4] pack-objects: support bitmaps and delta-islands with `--path-walk`

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 22, 2026, 07:35 UTC
Message-ID
<xmqqmrwn3u4x.fsf@gitster.g>
In-Reply-To
<cover.1782082975.git.me@ttaylorr.com>
Taylor Blau <me@ttaylorr.com> writes:
Show 38 quoted lines
> Note to the maintainer:
>
>  * This series is still based on 'ds/path-walk-filters' with Patrick's
>    'ps/clang-w-glibc-2.43-and-_Generic' merged in.
>
> Here is another small reroll of my series to make `--path-walk` work
> with reachability bitmaps and delta-islands.
>
> This round addresses Stolee's request to demonstrate the repack-size
> side of the integration between `--path-walk` and bitmap writing, and
> fixes an errant "grep" in the test suite.
>
> Changes since v2 include:
>
>  * p5311 now forces a fresh repack with '-F' when building its bitmapped
>    test repository. This avoids reusing deltas from a non-'--path-walk'
>    pack when we are trying to measure a pack produced by `--path-walk`.
>
>  * p5311 now records the size of the bitmapped pack, both with and
>    without `--path-walk`, to show that writing bitmaps during a
>    `--path-walk` repack does not lose the pack-size improvement that
>    `--path-walk` provides in repositories where it helps.
>
>  * The second patch's commit message has updated p5311 numbers from a
>    recent fluentui clone, fixing the "pack sizes" typo and documenting
>    the new bitmapped-pack-size comparison.
>
>  * The t5310 grep assertion now uses `test_grep`, as suggested by Junio.
>
> Outside of the above, the series is functionally unchanged.
>
> Thanks in advance for another look.
>
> Taylor Blau (4):
>   t/perf: drop p5311's lookup-table permutation
>   pack-objects: support reachability bitmaps with `--path-walk`
>   pack-objects: extract `record_tree_depth()` helper
>   pack-objects: support `--delta-islands` with `--path-walk`

Very cleanly implemented. I am not confident that I have followed the detailed logic around delta islands in the last step but the earlier three patches looked trivially good.

Thanks.  Will replace.
Previous: Taylor BlauNext: Derrick Stolee
Message 31 of 33 in “pack-objects: support bitmaps and delta-islands with `--path-walk`”
  1. 0/3 pack-objects: support bitmaps and delta-islands with `--path-walk`Taylor Blau, May 27, 2026
  2. 1/3 pack-objects: support reachability bitmaps with `--path-walk`Taylor Blau, May 27, 2026
  3. 2/3 pack-objects: extract `record_tree_depth()` helperTaylor Blau, May 27, 2026
  4. 3/3 pack-objects: support `--delta-islands` with `--path-walk`Taylor Blau, May 27, 2026
  5. Derrick StoleeMay 28, 2026
  6. Derrick StoleeMay 29, 2026
  7. Taylor BlauMay 29, 2026
  8. Derrick StoleeMay 29, 2026
  9. Taylor BlauMay 29, 2026
  10. 0/4 pack-objects: support bitmaps and delta-islands with `--path-walk`Taylor Blau, Jun 2, 2026
  11. 1/4 t/perf: drop p5311's lookup-table permutationTaylor Blau, Jun 2, 2026
  12. 2/4 pack-objects: support reachability bitmaps with `--path-walk`Taylor Blau, Jun 2, 2026
  13. Derrick StoleeJun 12, 2026
  14. Taylor BlauJun 19, 2026
  15. Derrick StoleeJun 19, 2026
  16. Taylor BlauJun 19, 2026
  17. Derrick StoleeJun 12, 2026
  18. Taylor BlauJun 19, 2026
  19. Derrick StoleeJun 19, 2026
  20. Taylor BlauJun 19, 2026
  21. Derrick StoleeJun 19, 2026
  22. Junio C HamanoJun 15, 2026
  23. Taylor BlauJun 19, 2026
  24. 3/4 pack-objects: extract `record_tree_depth()` helperTaylor Blau, Jun 2, 2026
  25. 4/4 pack-objects: support `--delta-islands` with `--path-walk`Taylor Blau, Jun 2, 2026
  26. 0/4 pack-objects: support bitmaps and delta-islands with `--path-walk`Taylor Blau, Jun 21, 2026
  27. 1/4 t/perf: drop p5311's lookup-table permutationTaylor Blau, Jun 21, 2026
  28. 2/4 pack-objects: support reachability bitmaps with `--path-walk`Taylor Blau, Jun 21, 2026
  29. 3/4 pack-objects: extract `record_tree_depth()` helperTaylor Blau, Jun 21, 2026
  30. 4/4 pack-objects: support `--delta-islands` with `--path-walk`Taylor Blau, Jun 21, 2026
  31. Junio C HamanoJun 22, 2026
  32. Derrick StoleeJun 22, 2026
  33. Junio C HamanoJun 22, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.