git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase: mention --abort alongside --continue

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 16, 2026, 17:24 UTC
Message-ID
<xmqqmrvqhmpp.fsf@gitster.g>
In-Reply-To
<4d150f21-46ea-4bf7-b516-c1763c152b34@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
> To me aborting a rebase because an exec command failed is almost never a 
> sensible route forward and we should not be encouraging users to abort 
> after a failed test - surely the sensible thing to do in that case is 
> fix the problem with "git commit --amend" and continue the rebase.

My conclusion, from my own experience with "git rebase", is the same.

I wonder if the workflow that benefits from this "if exec fails, give up and forget the whole thing" behavior is actually quite different from what we consider the "normal" use of the command? Perhaps the user is not interested in "rebasing" the history at all, but is instead running a check on each and every commit. That is, a more expensive version of:

        for commit in $(git rev-list bottom..top)
        do
                git reset --hard "$commit" &&
                do the exec command || break
        done
that just happens to be shorter to type?
Previous: Phillip WoodNext: Harald Nordgren
Message 11 of 14 in “rebase: mention --abort alongside --continue”
  1. rebase: mention --abort alongside --continueHarald Nordgren via GitGitGadget, Jun 15, 2026
  2. Phillip WoodJun 16, 2026
  3. Junio C HamanoJun 16, 2026
  4. Harald NordgrenJun 17, 2026
  5. Phillip WoodJun 17, 2026
  6. Junio C HamanoJun 17, 2026
  7. Harald NordgrenJun 18, 2026
  8. Junio C HamanoJun 19, 2026
  9. Harald NordgrenJul 16, 2026
  10. Phillip WoodJul 16, 2026
  11. Junio C HamanoJul 16, 2026
  12. Harald NordgrenJul 18, 2026
  13. Phillip WoodJul 18, 2026
  14. Junio C HamanoJul 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.