Re: [PATCH 0/2] git-config and large integers

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 20, 2013, 23:06 UTC
Message-ID: <xmqqli3wufmc.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20130820223953.GA3429@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 17 quoted lines

> I was playing with a hook for file size limits that wanted to store the
> limit in git-config. It turns out we don't do a very good job of big
> integers:
>
>   $ git config foo.size 2g
>   $ git config --int foo.size
>   -2147483648
>
> Oops. After this series, we properly notice the error:
>
>   $ git config --int foo.size
>   fatal: bad config value for 'foo.size' in .git/config
>
> and even better, provide a way to access large values:
>
>   $ git config --ulong foo.size
>   2147483648

I may be missing something, but why do we even need a new option for the command that is known to always produce textual output?

As you said "Oops", the first example that shows a string of digits prefixed by a minus sign for input "2g" is buggy, and I think it is perfectly reasonable to fix it to show a stringified representation of 2*1024*1024*1024 when asked for "--int".

What am I missing???