git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/5] replace: forbid replacing an object with one of a different type

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 29, 2013, 16:04 UTC
Message-ID
<xmqqli3k7abw.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20130829.082936.1893875995125817253.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
Show 5 quoted lines
> But if all the objects that point to an object, called O, are to be
> replaced, then in most cases object O probably doesn't need to be
> replaced. It's probably sufficient to create the new object, called
> O2, that would replace object O and to replace all the objects
> pointing to object O with objects pointing to O2.
Hmmmm.

What the above says, with "probably" and "most cases", can easily inferred by anybody remotely intelligent, and the only reason to have something like the above paragraph would be if it assures that the statement holds without these qualifications to weaken it, which it doesn't. I am not sure this paragraph adds much value.

> The only case where someone might really want to replace object 0,
> with an object O2 of a different type, and all the objects pointing to
> it, is if it's really important, perhaps for external reasons, to have
> object O's SHA1 point to O2.
The same comment applies here.
> And anyway, if one really wants to do that, it can still be done using
> "git update-ref".

And I really do not think this sentence is right---you can justify with the same sentence to remove "git replace" wrapper.

The earlier suggestion to bypass the new hand-holding with "--force" is more sensible, I think.

Previous: Christian CouderNext: Christian Couder
Message 7 of 13 in “Check replacement object type and minor updates”
  1. 0/5 Check replacement object type and minor updatesChristian Couder, Aug 27, 2013
  2. 1/5 replace: forbid replacing an object with one of a different typeChristian Couder, Aug 27, 2013
  3. Junio C HamanoAug 27, 2013
  4. Thomas RastAug 28, 2013
  5. Junio C HamanoAug 28, 2013
  6. Christian CouderAug 29, 2013
  7. Junio C HamanoAug 29, 2013
  8. Christian CouderAug 30, 2013
  9. Junio C HamanoAug 30, 2013
  10. 2/5 Documentation/replace: state that objects must be of the same typeChristian Couder, Aug 27, 2013
  11. 3/5 t6050-replace: test that objects are of the same typeChristian Couder, Aug 27, 2013
  12. 4/5 t6050-replace: add test to clean up all the replace refsChristian Couder, Aug 27, 2013
  13. 5/5 Documentation/replace: add Creating Replacement Objects sectionChristian Couder, Aug 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.