git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 6/8] mv: unindent one level for directory move code

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 12, 2014, 17:56 UTC
Message-ID
<xmqqlhqt617u.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CACsJy8B2P-UMvbkW2HtyxrYPP8TyXnt25CYw9=ZZp6Ks+ed=yA@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
Show 9 quoted lines
>> Otherwise, perhaps squash this in?
>
> Sure. But I'm having second thought about this series.
>
> mv.c is centered around files on worktree, which makes it pretty hard
> if we want to make it more like rm.c where index and worktree entries
> are treated more equally and pathspec is applied. Doing that in mv.c
> would require a lot more reorganization that makes this series
> obsolete.

Well, you may have started these as preparatory clean-up, but taken alone these are purely making the result more readable without changing any behaviour, so let's get them right first.

Thanks.
Previous: Duy NguyenNext: Nguyễn Thái Ngọc Duy
Message 10 of 12 in “builtin/mv.c cleanup”
  1. 0/8 builtin/mv.c cleanupNguyễn Thái Ngọc Duy, Aug 10, 2014
  2. 1/8 mv: mark strings for translationsNguyễn Thái Ngọc Duy, Aug 10, 2014
  3. 2/8 mv: flatten error handling code blockNguyễn Thái Ngọc Duy, Aug 10, 2014
  4. 3/8 mv: split submodule move preparation code outNguyễn Thái Ngọc Duy, Aug 10, 2014
  5. 4/8 mv: remove an "if" that's always trueNguyễn Thái Ngọc Duy, Aug 10, 2014
  6. 5/8 mv: move index search code outNguyễn Thái Ngọc Duy, Aug 10, 2014
  7. 6/8 mv: unindent one level for directory move codeNguyễn Thái Ngọc Duy, Aug 10, 2014
  8. Junio C HamanoAug 11, 2014
  9. Duy NguyenAug 12, 2014
  10. Junio C HamanoAug 12, 2014
  11. 7/8 mv: combine two if(s)Nguyễn Thái Ngọc Duy, Aug 10, 2014
  12. 8/8 mv: no SP between function name and the first opening parentheseNguyễn Thái Ngọc Duy, Aug 10, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.