git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH w/signoff] pre-push.sample: Remove unwanted `IFS=' '`.

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 21, 2014, 22:49 UTC
Message-ID
<xmqqlhm0botq.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAEE75_0Ff7NfQYUPrA414N9E0AE6LsS2zs0kL=BJ25bjPgom_w@mail.gmail.com>
Jim Hill <gjthill@gmail.com> writes:
> I call it unwanted because the default works fine with the actual
> input and explicitly limiting whitespace this way breaks most command
> substitution.
OK.  I'd call that "unnecessary", not "unwanted", though.

It becomes unwanted only when somebody cuts and pastes and changes what happens inside the body of the loop without thinking what IFS assignment is doing.

Leaving it to the default is not wrong per-se, but I think it is better to justify this change as protecting cut-and-paste people, which is its primary benefit as far as I can see.

Thanks for noticing.
Previous: Jim HillNext: Junio C Hamano
Message 5 of 7 in “pre-push.sample: Remove unwanted `IFS=' '`.”
  1. pre-push.sample: Remove unwanted `IFS=' '`.Jim Hill, Dec 21, 2014
  2. pre-push.sample: Remove unwanted `IFS=' '`.Jim Hill, Dec 21, 2014
  3. Junio C HamanoDec 21, 2014
  4. Jim HillDec 21, 2014
  5. Junio C HamanoDec 21, 2014
  6. Junio C HamanoDec 23, 2014
  7. pre-push.sample: remove unwanted `IFS=' '`.Jim Hill, Dec 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.