git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC v3 0/4] Improving performance of git clean

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 21, 2015, 19:02 UTC
Message-ID
<xmqqlhhlgv8y.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAMpP7NaUv10Ox0gNsE8cg4hUnNNiFi8NZSLw6F6SW+SLrt0VwQ@mail.gmail.com>
erik elfström <erik.elfstrom@gmail.com> writes:
Show 8 quoted lines
> Ok, thanks for looking into this.
>
> I have no well founded opinions on the implementation but I do
> think the performance tests would be more meaningful if the
> setup/cleanup code could be removed from the timed section.
> If the community agrees on an implementation I would be happy
> to convert the new tests, either directly in this series or as a follow
> up if that is preferred.

Let's not delay the fix and do the perf thing as a follow-up series, possibly an even independent one.

In other words, let's keep the topics small.
Show 15 quoted lines
>
> /Erik
>
> On Tue, Apr 21, 2015 at 12:14 AM, Thomas Gummerer <t.gummerer@gmail.com> wrote:
>> On 04/18, Erik Elfström wrote:
>>> * Still have issues in the performance tests, see comments
>>>   from Thomas Gummerer on v2
>>
>> I've looked at the "modern" style tests again, and I don't the code
>> churn is worth it just for using them for the performance tests.  If
>> anyone wants to take a look at the code, it's at
>> github.com/tgummerer/git tg/perf-lib.
>>
>> I think adding the test_perf_setup_cleanup command would make more
>> sense in this case.  If you want I can send a patch for that.
Previous: erik elfströmNext: Jeff King
Message 10 of 14 in “Improving performance of git clean”
  1. 0/4 Improving performance of git cleanErik Elfström, Apr 18, 2015
  2. 1/4 setup: add gentle version of read_gitfileErik Elfström, Apr 18, 2015
  3. 2/4 t7300: add tests to document behavior of clean and nested gitErik Elfström, Apr 18, 2015
  4. 3/4 p7300: add performance tests for cleanErik Elfström, Apr 18, 2015
  5. 4/4 clean: improve performance when removing lots of directoriesErik Elfström, Apr 18, 2015
  6. Junio C HamanoApr 19, 2015
  7. erik elfströmApr 21, 2015
  8. Thomas GummererApr 20, 2015
  9. erik elfströmApr 21, 2015
  10. Junio C HamanoApr 21, 2015
  11. Jeff KingApr 21, 2015
  12. erik elfströmApr 22, 2015
  13. Jeff KingApr 22, 2015
  14. erik elfströmApr 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.