Re: [PATCH] submodule: Fix regression for deinit without submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2016, 02:47 UTC
Message-ID: <xmqqlh59ewqe.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1458690134-538-1-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 21 quoted lines

> Per Cederqvist wrote:
>> It used to be possible to run
>>
>>    git submodule deinit -f .
>>
>> to remove any submodules, no matter how many submodules you had.  That
>> is no longer possible in projects that don't have any submodules at
>> all.  The command will fail with:
>>
>>     error: pathspec '.' did not match any file(s) known to git.
>
> This regression was introduced in 74703a1e4dfc (submodule: rewrite
> `module_list` shell function in C, 2015-09-02), as we optimized
> ...
>
> Reported-by: Per Cederqvist <cederp@opera.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>
>  Ok, let's try again. This is what I understand is the best bugfix for
>  2.8 and below. (This patch was developed on top of 2.7.4)

Thanks, let's aim to merge this for 2.8 final.