Re: [PATCH] git-send-email: Add ability to cc: any "trailers" from commit message

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2016, 18:11 UTC
Message-ID: <xmqqlgzc24hq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1472666194.4176.17.camel@perches.com>

Joe Perches <joe@perches.com> writes:

Show 24 quoted lines

> On Wed, 2016-08-31 at 10:54 -0700, Junio C Hamano wrote:
>> Joe Perches <joe@perches.com> writes:
>> 
>> > 
>> > Many commits have various forms of trailers similar to
>> >      "Acked-by: Name <address>" and "Reported-by: Name <address>"
>> > 
>> > Add the ability to cc these trailers when using git send-email.
>> I thought you were asking what we call these "<token> followed by
>> <colon>" at the end of the log message, and "footers or trailers"
>> was the answer.
>> 
>> I do not have a strong objection against limiting to "-by:" lines;
>> for one thing, it would automatically avoid having to worry about
>> "Bug-ID:" and other trailers that won't have e-mail address at all.
>> 
>> But if you are _only_ picking up "-by:" lines, then calling this
>> option "trailers" is way too wide and confusing.  I do not think
>> there is any specific name for "-by:" lines, though.  Perhaps you
>> would need to invent some name that has "-by" as a substring.
>> 
>> "any-by"?  or just "by"?  I dunno.
>
> Signatures?

Helped-by: and Reported-by: are often written by the author of the
patch and not by those who helped or reported, so calling them signatures
imply the author is forging them, too ;-)

I dunno.

Any name that hints that this applies only to the trailers that ends with "-by" is fine but "Signatures-by" does not sound very grammatical.