git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Protecting old temporary objects being reused from concurrent "git gc"?

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 16, 2016, 18:18 UTC
Message-ID
<xmqqlgwjqoe2.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20161116080753.gkn6v7vhdbifpubn@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> ... I notice there is
> a return very early on in update_one() when has_sha1_file() matches, and
> it seems like that would trigger in some interesting cases, too.

Yeah, I missed that. It says "we were asked to update one cache_tree that corresponds to this subdirectory, found that hashes everything below has been rolled up and still valid, and we already have the right tree object in the object store".

It can simply become freshen(), which is "do we have it in the object store?" with a side effect of touching iff the answer is "yes".

Previous: Jeff KingNext: Junio C Hamano
Message 9 of 13 in “Protecting old temporary objects being reused from concurrent "git gc"?”
  1. Matt McCutchenNov 15, 2016
  2. Jeff KingNov 15, 2016
  3. Matt McCutchenNov 15, 2016
  4. Jeff KingNov 15, 2016
  5. git-gc.txt: expand discussion of races with other processesMatt McCutchen, Nov 15, 2016
  6. Matt McCutchenNov 15, 2016
  7. Junio C HamanoNov 15, 2016
  8. Jeff KingNov 16, 2016
  9. Junio C HamanoNov 16, 2016
  10. Junio C HamanoNov 16, 2016
  11. Jeff KingNov 17, 2016
  12. Re* Protecting old temporary objects being reused from concurrent "git gc"?Junio C Hamano, Nov 17, 2016
  13. Jeff KingNov 17, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.