Re: [PATCH] remote-curl: don't hang when a server dies before any output
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 18, 2016, 18:28 UTC
- Message-ID
- <xmqqlgwgmylk.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20161118170147.g7nbkxpyihwkk6fw@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> So I don't feel like we have a good patch for the general case yet, and > I'm probably not going to get around to implementing it anytime soon. So > I'd suggest taking David's original patch (to punt when the response is > empty) in the meantime.
Yup, we are on the same page; the above matches what I wrote in the draft of the next issue of What's cooking report last night.
> I do think the commit message could be improved based on the discussion > here, though (at the very least to describe the nature of the deadlock, > and that we are choosing only one of the possible solutions, and why).
Thanks. That sounds sensible.