Re: [PATCH 1/2] Contextually notify user about an initial commit
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 19, 2017, 04:29 UTC
- Message-ID
- <xmqqlgoovbvm.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170619024123.5438-1-kaarticsivaraam91196@gmail.com>
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
Show 6 quoted lines
> A few alternatives considered were, > > * Waiting for initial commit > * Your current branch does not have any commits > * Current branch waiting for initial commit >
... "Decided to take the most succinct one." or something to conclude what happend to these alternatives would be nice to spell out as a conclusion here.
> Patch-derived-from: Junio C Hamano <gitster@pobox.com>
That's just "Helped-by:".
Show 8 quoted lines
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> > --- > Hope this would be final :) > > builtin/commit.c | 1 + > wt-status.c | 5 ++++- > wt-status.h | 1 + > 3 files changed, 6 insertions(+), 1 deletion(-)
Thanks. Have you run the full test suite after applying this patch?
Adjustment to existing tests to update their expectation would be a good thing to have in this patch that would easily illustaret what will change and how.
At least this would be needed; there may be other breakages.
diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh index 0b6da7ae1f..fa61b1a4ee 100755 --- a/t/t7501-commit.sh +++ b/t/t7501-commit.sh @@ -18,7 +18,7 @@ test_expect_success 'initial status' ' echo bongo bongo >file && git add file && git status >actual && - test_i18ngrep "Initial commit" actual + test_i18ngrep "No commits yet" actual ' test_expect_success 'fail initial amend' '