Re: [PATCH] git svn fetch: Create correct commit timestamp when using --localtime

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 7, 2017, 22:08 UTC
Message-ID: <xmqqlgmvni8x.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <ygf8tiyx480.fsf@tehran.isnogud.escape.de>

Urs Thuermann <urs@isnogud.escape.de> writes:

Show 8 quoted lines

> In parse_svn_date() prepend the correct UTC offset to the timestamp
> returned.  This is the offset in effect at the commit time instead of
> the offset in effect at calling time.
>
> Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>
> ---
>  perl/Git/SVN.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks; sounds sensible.

Eric?

Show 14 quoted lines

>
> diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
> index 98518f4..bc4eed3 100644
> --- a/perl/Git/SVN.pm
> +++ b/perl/Git/SVN.pm
> @@ -1416,7 +1416,7 @@ sub parse_svn_date {
>  			delete $ENV{TZ};
>  		}
>  
> -		my $our_TZ = get_tz_offset();
> +		my $our_TZ = get_tz_offset($epoch_in_UTC);
>  
>  		# This converts $epoch_in_UTC into our local timezone.
>  		my ($sec, $min, $hour, $mday, $mon, $year,