Re: difftool uses hardcoded perl shebang

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 19, 2017, 16:33 UTC
Message-ID: <xmqqlghywuct.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171219162528.GA5804@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> This is a build-time knob. When you build git, try:
>
>   make PERL_PATH='/usr/bin/env perl'
>
> (If you don't build your own git, then you might raise the issue with
> whomever packages your binary).

I somehow thought ANYTHING_PATH was meant to point at the exact path (as opposed to ANYTHING_COMMAND which is a command line), so it is within our rights to do

    test -x "$GIT_EXEC_PATH" || die "Your Git installation is broken"

but your suggestion above makes such a sanity check impossible.

I'd understand if it were

	make PERL_PATH=$(type --path perl)

of course, though.

> As an aside, git-difftool is now a C builtin these days, so the problem
> might also go away if you upgrade. ;)

Yup, true, true.