Re: [PATCH 2/2] cherry-pick: fix --quit not deleting CHERRY_PICK_HEAD
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 15, 2018, 17:33 UTC
- Message-ID
- <xmqqlg97ilfh.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CACsJy8CkXRc9NXRHt3a7=v04to0bMTvZo9x7zYNZWPiGDKQqdg@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
Show 11 quoted lines
> On Wed, Aug 15, 2018 at 7:26 PM Junio C Hamano <gitster@pobox.com> wrote: >> >> Please do not hide this bugfix behind 1/2 that is likely to require >> longer to cook than the fix itself. And more importantly, it makes >> it impossible to merge down the fix to the maintenance track, as I >> do not think we'd want to merge 1/2 there. > > Oh sorry I did not think about that. Will drop 1/2 and send 2/2 as > standalone. But for the record, I think this has been a bug since the > introduction of --quit in this command (back when it was still called > --reset).
If this bug has been there longer, it is a reason why we may want to ensure that the fix applies to even older maintenance tracks.
Thanks.