git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Using --word-diff breaks --color-moved

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 31, 2018, 04:27 UTC
Message-ID
<xmqqlg6eyc3u.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CA+X5Wn76N34oBhRZvXKOwP0L_pF=LYbT6ugTgtPYSvnHg=MZVw@mail.gmail.com>
james harvey <jamespharvey20@gmail.com> writes:
Show 7 quoted lines
> If you use both "--word-diff" and "--color-moved", regardless of the
> order of arguments, "--word-diff" takes precedence and "--color-moved"
> isn't allowed to do anything.
>
> I think "--color-moved" should have precedence over "--word-diff".  I
> cannot think of a scenario where a user would supply both options, and
> actually want "--word-diff" to take precedence.

I am not sure if I follow. If these two cannot work well together, then we should just reject the request as asking for incompatible combination of options while we are parsing the command line arguments, rather than arguing which one should trump the other one---that would simply lead to "in my opinion, word-diff is more important" vs "in mine, color-moved is more important", no?

Previous: james harveyNext: james harvey
Message 2 of 7 in “Using --word-diff breaks --color-moved”
  1. james harveyOct 31, 2018
  2. Junio C HamanoOct 31, 2018
  3. james harveyOct 31, 2018
  4. Stefan BellerOct 31, 2018
  5. Stefan BellerOct 31, 2018
  6. james harveyNov 2, 2018
  7. Stefan BellerNov 2, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.