Re: Git v2.21.0-rc0 broken on *BSD, maybe others

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 12, 2019, 17:07 UTC
Message-ID: <xmqqlg2ldjg4.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190212124323.GA11677@ash>

Duy Nguyen <pclouds@gmail.com> writes:

Show 20 quoted lines

> On Tue, Feb 12, 2019 at 01:13:35PM +0100, Ævar Arnfjörð Bjarmason wrote:
>> 
>> On Thu, Feb 07 2019, Junio C Hamano wrote:
>> 
>> > An early preview release Git v2.21.0-rc0 is now available for
>> > testing at the usual places.  It is comprised of 426 non-merge
>> > commits since v2.20.0, contributed by 57 people, 13 of which are
>> > new faces.
>> 
>> As seen on https://gitlab.com/git-vcs/git-ci/branches there are
>> regressions since 2.19.0, e.g. we have hard compile errors on BSD now,
>> and maybe AIX. I haven't dug into it.
>
> The build problem on BSD is known and being worked on [1]. I was going
> to install FreeBSD to examine it closey, but got distracted.
>
> The AIX problem is from d1dd94b308 (Do not print 'dangling' for
> cat-file in case of ambiguity - 2019-01-17). Apparently AIX compiler
> is a bit picky about enum being a strong or weak type. I like this
> compiler. The below patch should do.

Thanks.

If I find time later in the day, I may forge your sign-off and fabricate log messages for both patches, but unfortunately I need to run a long errand today during the day, so it may not happen.