Re: [RFC PATCH 0/5] oidmap: handle entries with the same key

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2019, 18:21 UTC
Message-ID: <xmqqlfx3p0zo.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <xmqqd0ikxok6.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 7 quoted lines

> Christian Couder <christian.couder@gmail.com> writes:
>
>> This is an RFC patch series that is not intended to be merged for now,
>> as it looks like we don't need oidmaps that can handle several entries
>> with the same key yet.
>
> What does it even mean for a map to allow multiple entries per key?

Ah, one thing that I was missing (perhaps it was obvious to everybody else but me X-<) was that this is merely to expose what is already available in the underlying hashmap API, so let's not bother with the "don't people usually do a single key to a value, which happens to be a bag of stuff (not just a single stuff)?" question.

And from that "a generic hashmap can do this, and an upcoming code needs to use a hashmap keyed with oid in the same fashion" point of view, the new wrappers the patches add all made sense to me.

Show 5 quoted lines

>> As I needed this for my work on reftable, I thought that...
>
> I actually think that showing how it is used in the real application
> (reftable?) is the best way to illustrate why this is useful and to
> get opinions from others.

This part still stands, though.

Thanks.