Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2020, 17:13 UTC
Message-ID: <xmqqlfqka4oe.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <b032358ca97df3bd5605ff356196f82a1f16a320.1578322213.git.gitgitgadget@gmail.com>

"elonderin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines

> From: elonderin <8225602+elonderin@users.noreply.github.com>
>
> The sentence wants to talk about the superproject's possesive, not plural form.
>
> Signed-off-by: thomas menzel dev@tomsit.de

The author of the patch must sign-off, so the above three lines should look more like so:

	From: Thomas Menzel <dev@tomsit.de>

	The sentence wants to talk about the superproject's
	possesive, not plural form.

	From: Thomas Menzel <dev@tomsit.de>

The content of the patch obviously is correct.

Thanks.

Show 17 quoted lines

> ---
>  Documentation/git-submodule.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
> index 22425cbc76..5232407f68 100644
> --- a/Documentation/git-submodule.txt
> +++ b/Documentation/git-submodule.txt
> @@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.
>  
>  absorbgitdirs::
>  	If a git directory of a submodule is inside the submodule,
> -	move the git directory of the submodule into its superprojects
> +	move the git directory of the submodule into its superproject's
>  	`$GIT_DIR/modules` path and then connect the git directory and
>  	its working directory by setting the `core.worktree` and adding
>  	a .git file pointing to the git directory embedded in the