Re: [PATCH] t2402: test worktree path when called in .git directory
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 13 quoted lines
> On Wed, Mar 4, 2020 at 2:00 AM Hariom Verma via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> The bug which reports an extra `/.git/.` in worktree path when called in
>> '.git' directory already has been fixed. But unfortunately, the regression
>> test to ensure this behavior has been forgotten.
>> Here is that test.
>
> For readers not involved in the discussion, this test was requested by
> [1], but the topic graduated to "next" before it could be re-rolled.
> It probably ought to be queued atop
> 'hv/receive-denycurrent-everywhere'.
>
> [1]: https://lore.kernel.org/git/CAPig+cTh-uu-obh9aeDOV9ptbVwRmkujgucbu9ei1Qa3qSNG_A@mail.gmail.com/
Your notes to those watching from sidelines are greatly appreciated.
Show 9 quoted lines
>> Signed-off-by: Hariom Verma <hariom18599@gmail.com>
>> ---
>> diff --git a/t/t2402-worktree-list.sh b/t/t2402-worktree-list.sh
>> @@ -151,4 +151,10 @@ test_expect_success 'linked worktrees are sorted' '
>> +test_expect_success 'worktree path when called in .git directory' '
>> + git worktree list> list1 &&
>> + git -C .git worktree list> list2 &&
>
> Nit: Style is for the redirection operator to stick to the file:
;-) Thanks for being a careful reader.
Show 7 quoted lines
> git worktree list >list1 &&
> git -C .git worktree list >list2 &&
>
>> + test_cmp list1 list2
>> +'
>
> The test itself makes sense.
Junio C Hamano <gitster@pobox.com>