git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-prompt.sh: make `option` a local variable

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 2, 2020, 20:39 UTC
Message-ID
<xmqqlffjtrvm.fsf@gitster.c.googlers.com>
In-Reply-To
<1d19cdf35c12b1079cee0861469dc1a652642c82.camel@mail.utoronto.ca>
Sibo Dong <sibo.dong@mail.utoronto.ca> writes:
> Thank you for the feedback Junio; I'm a bit new to contributing. Since
> you've justified this change much better than I have, is there any need
> for further action on my part?

The reviews by others are offered and taken as input to improve the patch(es), but they are merely sugestions. It is up to the original contributors to either disagree and not take them with explanation, or agree with and take them to improve their patch(es) before sending the next iteration.

So, at least you'd need to say if you agree with the suggested change and to what degree. Since you've done so, I can save one roundtrip by rewriting the proposed commit log message myself while queuing your patch ;-)

Thanks.
Previous: Sibo Dong
Message 4 of 4 in “git-prompt.sh: make `option` a local variable”
  1. git-prompt.sh: make `option` a local variableSibo Dong via GitGitGadget, Oct 31, 2020
  2. Junio C HamanoOct 31, 2020
  3. Sibo DongNov 1, 2020
  4. Junio C HamanoNov 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.