Re: [PATCH] pretty: lazy-load commit data when expanding user-format
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 28, 2021, 23:25 UTC
- Message-ID
- <xmqqlfccve2s.fsf@gitster.c.googlers.com>
- In-Reply-To
- <YBMXM83xCZvC5WyA@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 10 quoted lines
> I added the final test to show where we don't improve (the 1% there is > just lucky noise), but also as a regression test to make sure we're not > doing anything stupid like loading the commit multiple times when there > are several placeholders that need it. > > Reported-by: Michael Haggerty <mhagger@alum.mit.edu> > Signed-off-by: Jeff King <peff@peff.net> > --- > This benefits "rev-list --format=", as well, though there you can also > use things like "--parents" instead, which are already fast.
Quite pleased to see more work lazily done (and personally I am happy to see Michael's name on the list---say Hi, I missed him).