Re: [PATCH v2] i18n.txt: camel case and monospace "i18n.commitEncoding"

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 23, 2021, 19:41 UTC
Message-ID: <xmqqlfbe1sim.fsf@gitster.g>
In-Reply-To: <CAPig+cSSnx3y1Uh6uLvdiMn_xg2--w2-_4VDLqXYJ+WARhc6Gg@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 17 quoted lines

> On Tue, Feb 23, 2021 at 2:28 PM Junio C Hamano <gitster@pobox.com> wrote:
>> In 95791be750 (doc: camelCase the i18n config variables to improve
>> readability, 2017-07-17), the other i18n config variables were
>> camel cased. However, this one instance was missed.
>>
>> Camel case and monospace "i18n.commitEncoding" so that it matches the
>> surrounding text.
>>
>> Signed-off-by: Denton Liu <liu.denton@gmail.com>
>> [jc: fixed 3 other mistakes that are exactly the same]
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>>  * So, while I still remember, I amended your commit and queued
>>    this.
>
> Denton's authorship seems to have been lost (no From: header). Was
> that intentional?

I didn't even notice.

I actually expect that Denton will produce a more complete series based on the "comm -3" output, so that this patch itself (or its authorship) won't matter ;-)

And I also expect that somebody will take the "two greps and comm" trick I showed and wrap it into some form of doc-lint. Hint, hint...

Thanks.