Re: [PATCH v11 3/3] grep: fix an edge case concerning ascii patterns and UTF-8 data
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 9, 2021, 06:44 UTC
- Message-ID
- <xmqqlf32g0jl.fsf@gitster.g>
- In-Reply-To
- <20211007203148.23888-3-someguy@effective-light.com>
Hamza Mahfooz <someguy@effective-light.com> writes:
Show 9 quoted lines
> diff --git a/t/t7812-grep-icase-non-ascii.sh b/t/t7812-grep-icase-non-ascii.sh > index e5d1e4ea68..42323b31c0 100755 > --- a/t/t7812-grep-icase-non-ascii.sh > +++ b/t/t7812-grep-icase-non-ascii.sh > @@ -53,6 +53,54 @@ test_expect_success REGEX_LOCALE 'pickaxe -i on non-ascii' ' > ... > + git add file5 && > + export GIT_COMMITTER_NAME="Ç O Mîtter" && > + export GIT_COMMITTER_EMAIL="committer@example.com" &&
These lines are flagged as an error by test-lint; I've queued this on top to make today's integration result to pass our tests.
Thanks.
t/t7812-grep-icase-non-ascii.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t7812-grep-icase-non-ascii.sh b/t/t7812-grep-icase-non-ascii.sh index 42323b31c0..313d4894ad 100755 --- a/t/t7812-grep-icase-non-ascii.sh +++ b/t/t7812-grep-icase-non-ascii.sh @@ -72,8 +72,8 @@ test_expect_success GETTEXT_LOCALE,PCRE 'log --committer with an ascii pattern o EOF test_write_lines "fifth" >file5 && git add file5 && - export GIT_COMMITTER_NAME="Ç O Mîtter" && - export GIT_COMMITTER_EMAIL="committer@example.com" && + GIT_COMMITTER_NAME="Ç O Mîtter" GIT_COMMITTER_EMAIL="committer@example.com" && + export GIT_COMMITTER_NAME GIT_COMMITTER_EMAIL && git -c i18n.commitEncoding=latin1 commit -m thïrd && git -c i18n.logOutputEncoding=latin1 log -1 --pretty=fuller --color=always --perl-regexp --committer=" O.*" >log && grep Commit: log >actual.raw &&
-- 2.33.0-960-g8d902839aa