Re: [PATCH 3/9] trace2: defer free of TLS CTX until program exit.

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 21, 2021, 07:30 UTC
Message-ID: <xmqqlf0equs3.fsf@gitster.g>
In-Reply-To: <e0c41e1fc7895ba67d7536115cd8c1598439ded1.1640012469.git.gitgitgadget@gmail.com>

"Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 9 quoted lines

> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> Defer freeing of the Trace2 thread CTX data until program exit.
> Create a global list of thread CTX data to own the storage.
>
> TLS CTX data is allocated when a thread is created and associated
> with that thread.  Previously, that storage was deleted when the
> thread exited.  Now we simply disassociate the CTX data from the
> thread when it exits and let the global CTX list manage the cleanup.

By the way, TLS CTX sounds embarrassingly close and confusing to some function that we may find in say openssl or some crypto stuff X-<. Was there a strong reason to avoid calling these functions and types something like tr2_thread_ctx instead of tr2tls_thread_ctx?