Re: [PATCH] cocci: avoid "should ... be a metavariable" warnings

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 30, 2022, 22:26 UTC
Message-ID: <xmqqlensulit.fsf@gitster.g>
In-Reply-To: <patch-1.1-31af153702e-20221130T082521Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 17 quoted lines

> Since [1] running "make coccicheck" has resulted in [2] being emitted
> to the *.log files for the "spatch" run, and in the case of "make
> coccicheck-test" we'd emit these to the user's terminal.
>
> Nothing was broken as a result, but let's refactor the relevant rules
> to eliminate the ambiguity between a possible variable and an
> identifier.
>
> 1. 0e6550a2c63 (cocci: add a index-compatibility.pending.cocci,
>    2022-11-19)
> 2. warning: line 257: should active_cache be a metavariable?
>    warning: line 260: should active_cache_changed be a metavariable?
>    warning: line 263: should active_cache_tree be a metavariable?
>    warning: line 271: should active_nr be a metavariable?
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---

Thanks.  Queued.