git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] rebase: clarify conditionals in todo_list_to_strbuf()

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 10, 2023, 16:03 UTC
Message-ID
<xmqqleeihok5.fsf@gitster.g>
In-Reply-To
<ZNTTTAtNE2/DY9vT@ugly>
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
Show 7 quoted lines
> On Wed, Aug 09, 2023 at 12:39:37PM -0700, Junio C Hamano wrote:
>>Thanks.  Then this patch is still a strict "Meh" to me.
>>
> i can't really think of a reason why you reject such a no-brainer
> other than that you consider it churn. in that case i need to tell you
> that you have unreasonable standards, which actively contribute to the
> code remaining a mess.
An ad-hominem remark is a signal that it is good time to disengage.

There are certain style differences that may be acceptable if it were written from the get-go, but it is not worth the patch churn to switch once it is in the tree. This one squarely falls into that category.

Bye.
Previous: Oswald BuddenhagenNext: Oswald Buddenhagen
Message 12 of 14 in “rebase: clarify conditionals in todo_list_to_strbuf()”
  1. rebase: clarify conditionals in todo_list_to_strbuf()Oswald Buddenhagen, Mar 23, 2023
  2. Taylor BlauMar 23, 2023
  3. Oswald BuddenhagenMar 24, 2023
  4. Phillip WoodMar 24, 2023
  5. rebase: clarify conditionals in todo_list_to_strbuf()Oswald Buddenhagen, Apr 28, 2023
  6. Felipe ContrerasMay 2, 2023
  7. rebase: clarify conditionals in todo_list_to_strbuf()Oswald Buddenhagen, Aug 7, 2023
  8. Junio C HamanoAug 7, 2023
  9. Oswald BuddenhagenAug 9, 2023
  10. Junio C HamanoAug 9, 2023
  11. Oswald BuddenhagenAug 10, 2023
  12. Junio C HamanoAug 10, 2023
  13. Oswald BuddenhagenAug 11, 2023
  14. Richard KerryAug 11, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.