Re: [PATCH v4 1/2] t0091-bugreport: stop using i18ngrep

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 29, 2023, 23:59 UTC
Message-ID: <xmqqleblgeti.fsf@gitster.g>
In-Reply-To: <20231026182231.3369370-2-nasamuffin@google.com>

emilyshaffer@google.com writes:

Show 8 quoted lines

> From: Emily Shaffer <nasamuffin@google.com>
>
> Since e6545201ad (Merge branch 'ab/detox-config-gettext', 2021-04-13),
> test_i18ngrep is no longer required. Quit using it in the bugreport
> tests, since it's setting a bad example for tests added later.
>
> Signed-off-by: Emily Shaffer <nasamuffin@google.com>
> ---

Makes sense.  Thanks.

Show 15 quoted lines

>  t/t0091-bugreport.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0091-bugreport.sh b/t/t0091-bugreport.sh
> index f6998269be..e1588f71b7 100755
> --- a/t/t0091-bugreport.sh
> +++ b/t/t0091-bugreport.sh
> @@ -65,7 +65,7 @@ test_expect_success '--output-directory puts the report in the provided dir' '
>  
>  test_expect_success 'incorrect arguments abort with usage' '
>  	test_must_fail git bugreport --false 2>output &&
> -	test_i18ngrep usage output &&
> +	grep usage output &&
>  	test_path_is_missing git-bugreport-*
>  '