Re: [GSoC][PATCH v3] t: migrate helper/test-oidmap.c to unit-tests/t-oidmap.c

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 3, 2024, 16:20 UTC
Message-ID: <xmqqle2ie9b4.fsf@gitster.g>
In-Reply-To: <20240703062958.23262-2-shyamthakkar001@gmail.com>

Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes:

Show 10 quoted lines

> helper/test-oidmap.c along with t0016-oidmap.sh test the oidmap.h
> library which is built on top of hashmap.h.
>
> Migrate them to the unit testing framework for better performance,
> concise code and better debugging. Along with the migration also plug
> memory leaks and make the test logic independent for all the tests.
> The migration removes 'put' tests from t0016, because it is used as
> setup to all the other tests, so testing it separately does not yield
> any benefit.
>

Show 6 quoted lines

> Helped-by: Junio C Hamano <gitster@pobox.com>
> Helped-by: Phillip Wood <phillip.wood123@gmail.com>
> Reviewed-by: Josh Steadmon <steadmon@google.com>
> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
> Signed-off-by: Ghanshyam Thakkar <shyamthakkar001@gmail.com>

The trailer lines should come more-or-less in chronological order. I do not know exact sequence of events, but mentoring would have happened first before the initial iteration was posted, then Phillip helped to improve it during iterations, the latest was reviewed by Josh and then you folded the little test improvement from me and Phillip? And to seal the whole thing off, you add your sign-off at the end.

Technically speaking, any change after a review invalidates an earlier "Reviewed-by", but the updates we see here, relative to the iteration that received the "Reviewed-by", are not significant or large enough to warrant that, so let's pretend that Josh would be happy with the end result, even with our little additions.

Which leads us to the trailer lines ordered like so:

    Mentored-by: Christian Couder <chriscool@tuxfamily.org>
    Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
    Helped-by: Phillip Wood <phillip.wood123@gmail.com>
    Helped-by: Junio C Hamano <gitster@pobox.com>
    Reviewed-by: Josh Steadmon <steadmon@google.com>
    Signed-off-by: Ghanshyam Thakkar <shyamthakkar001@gmail.com>

The changes since the previous round look exactly as expected. Looking very good.

Will queue.  Let's mark it for 'next'.

Thanks.