Re: [PATCH] Makefile: don't remove configure on distclean

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 5, 2024, 18:35 UTC
Message-ID: <xmqqldxxsf4p.fsf@gitster.g>
In-Reply-To: <76f4dfe6-3724-472b-9b42-c91926e61fd1@maxsi.org>

Jonas 'Sortie' Termansen <sortie@maxsi.org> writes:

Show 6 quoted lines

> make distclean conventionally restores the extracted release tarball to
> its original distributed contents by cleaning the source code for
> distribution. However, the configure script is part of the distribution
> and should not be removed. This behavior is creating problems on my
> package infrastructure where configure-based packages have make
> distclean run afterwards and then the subsequent git build fails.

Without a target that truly cleans any build artifacts over what is recorded in the commit to replace "make distclean", this is a regression. It seems people use "make reallyclean" or something for that, perhaps?

Show 17 quoted lines

> Signed-off-by: Jonas 'Sortie' Termansen <sortie@maxsi.org>
> ---
>  Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 6f5986b66e..c488b914a0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3723,7 +3723,6 @@ dist-doc: git$X
>  ### Cleaning rules
>  
>  distclean: clean
> -	$(RM) configure
>  	$(RM) config.log config.status config.cache
>  	$(RM) config.mak.autogen config.mak.append
>  	$(RM) -r autom4te.cache