Re: [PATCH] [GSoC Patch] Modernize Test Path Checking in Git’s Test Suite
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 18, 2025, 23:53 UTC
- Message-ID
- <xmqqldt1zyia.fsf@gitster.g>
- In-Reply-To
- <CAPig+cSXiKOBq_+9+uDTFOLf5F8+KPocwXVX2VzPQAxJHQL99w@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 6 quoted lines
> Referring to the other thread at [*], perhaps this (avoiding `!` in > front of test_path_*) is yet another clarification which ought to be > added to the microproject description in order to lead candidates in a > more profitable direction. > > [*]: https://lore.kernel.org/git/CAPig+cRm+sc+Rk-4SuQ5CrPeZLG2Nzz9B7+6OZxCq7tV5mzmBA@mail.gmail.com/
While mentors do that, I'd prefer to see others extend support for
test_path_is_file ! this-should-not-be-file
so that the students have a better tool to work with.
> One other recommendation I would make is to restrict the microproject > submission to just a single test script (rather than updating twelve > of them) in order to avoid exhausting the pool for other potential > candidates.
Yes, you made that point in the other thread, and I agree with it 100%.
Thanks.