Re: [PATCH] config.mak.uname: update settings for OpenBSD

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 2, 2025, 05:01 UTC
Message-ID: <xmqqldqavis7.fsf@gitster.g>
In-Reply-To: <aD0XIxPRQjA5t8oi@humpty.home.comstyle.com>

Brad Smith <brad@comstyle.com> writes:

Show 7 quoted lines

> OpenBSD requires DIR_HAS_BSD_GROUP_SEMANTICS.
>
> OpenBSD has never had the BSD sysctl KERN_PROC_PATHNAME nor
> does it support or use the /proc filesystem.
>
> OpenBSD has had strcasestr() since 3.8. OpenBSD has had memmem()
> since 5.4.

;-) Thanks.

5.4 was from Nov 2013 if I can trust https://undeadly.org/cgi?action=article;sid=20131101142807 and it is about time we adjust ourselves to the more recent world order.

Will apply.  Thanks.

Show 28 quoted lines

> Signed-off-by: Brad Smith <brad@comstyle.com>
> ---
>  config.mak.uname | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index df172d5871..5a0b4200c3 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -301,17 +301,14 @@ ifeq ($(uname_S),FreeBSD)
>  	FILENO_IS_A_MACRO = UnfortunatelyYes
>  endif
>  ifeq ($(uname_S),OpenBSD)
> -	NO_STRCASESTR = YesPlease
> -	NO_MEMMEM = YesPlease
> +	DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
>  	USE_ST_TIMESPEC = YesPlease
>  	NEEDS_LIBICONV = YesPlease
>  	BASIC_CFLAGS += -I/usr/local/include
>  	BASIC_LDFLAGS += -L/usr/local/lib
>  	HAVE_PATHS_H = YesPlease
>  	HAVE_BSD_SYSCTL = YesPlease
> -	HAVE_BSD_KERN_PROC_SYSCTL = YesPlease
>  	CSPRNG_METHOD = arc4random
> -	PROCFS_EXECUTABLE_PATH = /proc/curproc/file
>  	FREAD_READS_DIRECTORIES = UnfortunatelyYes
>  	FILENO_IS_A_MACRO = UnfortunatelyYes
>  endif