Re: [PATCH 0/2] [GSoC Patch] t2000: modernize path checks to use helper functions

From: Junio C Hamano <gitster@pobox.com>
Date: May 24, 2026, 09:55 UTC
Message-ID: <xmqqldd9i12i.fsf@gitster.g>
In-Reply-To: <pull.2256.git.git.1779534462.gitgitgadget@gmail.com>

"Zakariyah Ali via GitGitGadget" <gitgitgadget@gmail.com> writes:

> This is my GSoC microproject submission modernizing test path checks in
> t/t2000-conflict-when-checking-files-out.sh.

I do not quite get where you intend to fit these two patches.

> base-commit: 60f07c4f5c5f81c8a994d9e06b31a4a3a1679864

This is fairly old, v2.54.0-rc2~9.

But the thing is, your earlier clean-up to this t2000 script 4a9e0972 (t2000: consolidate second scenario into a single test block, 2026-04-29) was queued on za/t2000-modernise-more was merged to 'master' at b5d94909 (Merge branch 'za/t2000-modernise-more', 2026-05-21). But what is most curious about these two patches is that the [PATCH 1/2] starts like so:

    From: Zakariyah Ali <zakariyahali100@gmail.com>

    Now that the test script has been modernised, consolidate the eight
    separate test_expect_success blocks ...

I take that to be a reference to your previous effort in za/t2000-modernise-more topic. But these two patches are changing the code as if that did not even exist.

If the za/t2000-modernise-more topic were still not merged to 'next', sending in replacement patches works just fine. but a new patch that ignores anything that have already been merged to 'next' or 'master' is counter-productive.

> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2256%2Falibaba0010%2Fmodernize-test-path-checking-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2256/alibaba0010/modernize-test-path-checking-v1
> Pull-Request: https://github.com/git/git/pull/2256