Re: [PATCH v2] completion: zsh: support completion after "git -C <path>"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 26, 2026, 22:04 UTC
- Message-ID
- <xmqqld9sczd0.fsf@gitster.g>
- In-Reply-To
- <pull.2155.v2.git.1787144872870.gitgitgadget@gmail.com>
"Lutz Lengemann via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 26 quoted lines
> From: Lutz Lengemann <lutz@lengemann.net> > > The zsh completion wrapper does not handle the global -C option, so > > git -C <path> <command> <TAB> > > offers nothing. -C is not part of the _arguments specification, and the > wrapper hard-codes __git_cmd_idx=1, i.e. it assumes that the command is > the first argument, so the bash helpers look at the wrong word. The > latter is not specific to -C; the assumption breaks after any global > option, e.g. "git -p checkout <TAB>" does not complete branch names. > > Add -C to the specification, and find the command by skipping over the > global options and, where they take one, their arguments, as __git_main > in git-completion.bash does. The index is one less than zsh's, as the > helpers count the words from zero. Collect the paths given to -C into > __git_C_args, or else the helpers run git in the current directory and > fail to resolve the aliases and refs of the repository the command runs > in. > > The argument of a -C is still completed without regard for the -C > options before it, i.e. "git -C dir -C <TAB>" offers the directories in > ".", not the ones in "dir". > > Signed-off-by: Lutz Lengemann <lutz@lengemann.net> > ---
Let me mark the topic for 'next', as later parts of the thread was about an unrelated tangent.