Re: [PATCH v2] git-p4: avoid shell interpretation of commit ids in applyCommit
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 2, 2026, 09:31 UTC
- Message-ID
- <xmqqld7blguy.fsf@gitster.g>
- In-Reply-To
- <pull.2411.v2.git.git.1790238482045.gitgitgadget@gmail.com>
"Anupam Mediratta via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 15 quoted lines
> The shell-based call that applied the patch for real went through > git-p4.py's own system() helper, which raises CalledProcessError on a > non-zero exit status, so a failed apply aborted the submit. Keep that > behaviour by giving the new helper the same ignore_error contract > system() uses: it raises unless the caller asks for the status, and the > two callers that test the status for themselves ask for it. > > Add a regression test exercising `git p4 submit --commit` with a shell > metacharacter payload, verifying it is never interpreted. > > Signed-off-by: Anupam Mediratta <mediratta@gmail.com> > --- > > I have read https://git-scm.com/docs/SubmittingPatches#ai and confirm > this contribution complies with it.
I do not know what this means, but anyway.
This round unfortunately saw interest and reviews on the list from nobody. Unless we see some volunteers to give it a review in a few weeks, I will discard the topic out of my tree, as 'seen' has been crowded with topics that have been collecting dust without getting many reviews.
Thanks.