git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] git-p4: avoid shell interpretation of commit ids in applyCommit

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 2, 2026, 09:31 UTC
Message-ID
<xmqqld7blguy.fsf@gitster.g>
In-Reply-To
<pull.2411.v2.git.git.1790238482045.gitgitgadget@gmail.com>
"Anupam Mediratta via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 15 quoted lines
> The shell-based call that applied the patch for real went through
> git-p4.py's own system() helper, which raises CalledProcessError on a
> non-zero exit status, so a failed apply aborted the submit. Keep that
> behaviour by giving the new helper the same ignore_error contract
> system() uses: it raises unless the caller asks for the status, and the
> two callers that test the status for themselves ask for it.
>
> Add a regression test exercising `git p4 submit --commit` with a shell
> metacharacter payload, verifying it is never interpreted.
>
> Signed-off-by: Anupam Mediratta <mediratta@gmail.com>
> ---
>
>     I have read https://git-scm.com/docs/SubmittingPatches#ai and confirm
>     this contribution complies with it.
I do not know what this means, but anyway.

This round unfortunately saw interest and reviews on the list from nobody. Unless we see some volunteers to give it a review in a few weeks, I will discard the topic out of my tree, as 'seen' has been crowded with topics that have been collecting dust without getting many reviews.

Thanks.
Previous: Anupam Mediratta via GitGitGadget
Message 4 of 4 in “git-p4: avoid shell interpretation of commit ids in applyCommit”
  1. git-p4: avoid shell interpretation of commit ids in applyCommitAnupam Mediratta via GitGitGadget, Sep 22, 2026
  2. Junio C HamanoSep 23, 2026
  3. git-p4: avoid shell interpretation of commit ids in applyCommitAnupam Mediratta via GitGitGadget, Sep 24, 2026
  4. Junio C HamanoNov 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.