git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 2/6] Add git_env_ulong() to parse environment variable

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 28, 2014, 17:13 UTC
Message-ID
<xmqqk35sbkra.fsf@gitster.dls.corp.google.com>
In-Reply-To
<7AD881F3-DDD0-4094-90F3-C3E2F81DF664@zib.de>
Steffen Prohaska <prohaska@zib.de> writes:
Show 16 quoted lines
>> OK, then let's do that at least for now and move on.
>
> Ok.  I saw that you tweaked my patch on pu.  Maybe remove the outdated
> comment above the function completely:
>
> diff --git a/config.c b/config.c
> index 87db755..010bcd0 100644
> --- a/config.c
> +++ b/config.c
> @@ -1122,9 +1122,6 @@ int git_env_bool(const char *k, int def)
>         return v ? git_config_bool(k, v) : def;
>  }
>
> -/*
> - * Use default if environment variable is unset or empty string.
> - */
Thanks, will do.
Show 8 quoted lines
>  unsigned long git_env_ulong(const char *k, unsigned long val)
>  {
>         const char *v = getenv(k);
>
> 	Steffen--
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous: Steffen ProhaskaNext: Steffen Prohaska
Message 11 of 19 in “Stream fd to clean filter; GIT_MMAP_LIMIT, GIT_ALLOC_LIMIT with git_env_ulong()”
  1. 0/6 Stream fd to clean filter; GIT_MMAP_LIMIT, GIT_ALLOC_LIMIT with git_env_ulong()Steffen Prohaska, Aug 26, 2014
  2. 1/6 convert: drop arguments other than 'path' from would_convert_to_git()Steffen Prohaska, Aug 26, 2014
  3. 2/6 Add git_env_ulong() to parse environment variableSteffen Prohaska, Aug 26, 2014
  4. Jeff KingAug 26, 2014
  5. Junio C HamanoAug 26, 2014
  6. Jeff KingAug 26, 2014
  7. Junio C HamanoAug 26, 2014
  8. Jeff KingAug 27, 2014
  9. Junio C HamanoAug 27, 2014
  10. Steffen ProhaskaAug 28, 2014
  11. Junio C HamanoAug 28, 2014
  12. 3/6 Change GIT_ALLOC_LIMIT check to use git_env_ulong()Steffen Prohaska, Aug 26, 2014
  13. 4/6 Introduce GIT_MMAP_LIMIT to allow testing expected mmap sizeSteffen Prohaska, Aug 26, 2014
  14. 5/6 Change copy_fd() to not close input fdSteffen Prohaska, Aug 26, 2014
  15. Junio C HamanoAug 26, 2014
  16. Jeff KingAug 26, 2014
  17. Steffen ProhaskaAug 28, 2014
  18. Junio C HamanoAug 28, 2014
  19. 6/6 convert: stream from fd to required clean filter to reduce used address spaceSteffen Prohaska, Aug 26, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.