Re: [PATCH 1/2] check-headers: add header usage checks for .c files

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 15, 2014, 19:16 UTC
Message-ID: <xmqqk35466e1.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1410680445-84593-1-git-send-email-davvid@gmail.com>

David Aguilar <davvid@gmail.com> writes:

Show 15 quoted lines

> Teach check-header.sh to ensure that the first included header in .c
> files is either git-compat-util.h, builtin.h, or cache.h.
>
> Ensure that common-cmds.h is only included by help.c.
>
> Move the logic into functions so that we can skip parts of the check.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
> This depends on my previous patch that adds check-header.sh.
> ...
> +check_headers () {
> +	for header in *.h ewah/*.h vcs-svn/*.h xdiff/*.h
> +	do
> +		check_header "$header"

Hmmmm, doesn't check_header run "$@" as a command?