git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v15 11/11] Documentation: add documentation for 'git interpret-trailers'

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 22, 2014, 21:23 UTC
Message-ID
<xmqqk34vjqni.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140920134515.18999.58095.chriscool@tuxfamily.org>

This has quite a few "trailing whitespace" errors in the patch in the documentation part. It would mean that people who try to follow along the examples would have difficult time deciphering where trailing whitespaces are necessary.

For example
Show 14 quoted lines
> +* Configure a commit template with some trailers with empty values,
> +  then configure a commit-msg hook that uses 'git interpret-trailers'
> +  to remove trailers with empty values and to add a 'git-version'
> +  trailer:
> ++
> +------------
> +$ cat >commit_template.txt <<EOF
> +> ***subject***
> +> 
> +> ***message***
> +> 
> +> Fixes: 
> +> Cc: 
> ...

This presents the example in the least useful way. The leading "> " are coming from $PS2 so people cannot cut & paste to follow along on their interactive shell session, but cutting and pasting from a machine-readable copy of the document would be the only way to preserve the trailing SP on lines that begin with Fixes:, Cc: and friends. On the other hand, those who type each line while eyeballing the documentation (because it is not cut-and-paste ready due to $PS2) may not spot the trailing SP on these lines.

Can we think of a way to make the necessary trailing SP stand out?
Previous: Christian Couder
Message 13 of 13 in “Add interpret-trailers builtin”
  1. 00/11 Add interpret-trailers builtinChristian Couder, Sep 20, 2014
  2. 01/11 trailer: add data structures and basic functionsChristian Couder, Sep 20, 2014
  3. 02/11 trailer: process trailers from input message and argumentsChristian Couder, Sep 20, 2014
  4. 03/11 trailer: read and process config informationChristian Couder, Sep 20, 2014
  5. 04/11 trailer: process command line trailer argumentsChristian Couder, Sep 20, 2014
  6. 05/11 trailer: parse trailers from file or stdinChristian Couder, Sep 20, 2014
  7. 06/11 trailer: put all the processing together and printChristian Couder, Sep 20, 2014
  8. 07/11 trailer: add interpret-trailers commandChristian Couder, Sep 20, 2014
  9. 08/11 trailer: add tests for "git interpret-trailers"Christian Couder, Sep 20, 2014
  10. 09/11 trailer: execute command from 'trailer.<name>.command'Christian Couder, Sep 20, 2014
  11. 10/11 trailer: add tests for commands in config fileChristian Couder, Sep 20, 2014
  12. 11/11 Documentation: add documentation for 'git interpret-trailers'Christian Couder, Sep 20, 2014
  13. Junio C HamanoSep 22, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.