git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] unpack-trees: don't update files flagged for deletion

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 17, 2015, 20:05 UTC
Message-ID
<xmqqk2ty1reo.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1437162532-31933-1-git-send-email-dturner@twopensource.com>
David Turner <dturner@twopensource.com> writes:
> Don't update files in the worktree from cache entries which are
> flagged with CE_WT_REMOVE.  This is fixes merges in sparse
> checkouts.
s/This is/This/;

But more importantly, what is missing is "why" it is a good fix. i.e. things like:

 - why is it wrong to update what is marked with CE_UPDATE bit to be
   updated in the working tree when CE_WT_REMOVE bit is on?
 - how that incorrect operation breaks which operation in what way?
 - how does the changed code fix that breakage?
Previous: David TurnerNext: David Turner
Message 2 of 8 in “unpack-trees: don't update files flagged for deletion”
  1. unpack-trees: don't update files flagged for deletionDavid Turner, Jul 17, 2015
  2. Junio C HamanoJul 17, 2015
  3. unpack-trees: don't update files with CE_WT_REMOVE setDavid Turner, Jul 17, 2015
  4. Junio C HamanoJul 17, 2015
  5. Duy NguyenJul 18, 2015
  6. Junio C HamanoJul 18, 2015
  7. Junio C HamanoJul 21, 2015
  8. David TurnerJul 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.