git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] gc: remove unused #include "sigchain.h"

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 22, 2015, 20:14 UTC
Message-ID
<xmqqk2qer78a.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1445517810-13998-2-git-send-email-tklauser@distanz.ch>
Tobias Klauser <tklauser@distanz.ch> writes:
Show 6 quoted lines
> After switching to use the tempfile module in commit ebebeaea (gc: use
> tempfile module to handle gc.pid file), no declarations from sigchain.h
> are used in builtin/gc.c anymore. Thus, remove the #include.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---

I'll drop this one as we seem to have gained another user of the API in this file in the nd/gc-auto-background-fix topic.

Show 14 quoted lines
>  builtin/gc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/builtin/gc.c b/builtin/gc.c
> index 9ff0204..dc8a242 100644
> --- a/builtin/gc.c
> +++ b/builtin/gc.c
> @@ -15,7 +15,6 @@
>  #include "lockfile.h"
>  #include "parse-options.h"
>  #include "run-command.h"
> -#include "sigchain.h"
>  #include "argv-array.h"
>  #include "commit.h"
Previous: Tobias KlauserNext: Tobias Klauser
Message 3 of 11 in “Remove unused #include "sigchain.h"”
  1. 0/5 Remove unused #include "sigchain.h"Tobias Klauser, Oct 22, 2015
  2. 1/5 gc: remove unused #include "sigchain.h"Tobias Klauser, Oct 22, 2015
  3. Junio C HamanoOct 22, 2015
  4. Tobias KlauserOct 23, 2015
  5. Junio C HamanoOct 23, 2015
  6. 2/5 credential-cache--daemon: remove unused #include "sigchain.h"Tobias Klauser, Oct 22, 2015
  7. 3/5 diff: remove unused #include "sigchain.h"Tobias Klauser, Oct 22, 2015
  8. 4/5 read-cache: remove unused #include "sigchain.h"Tobias Klauser, Oct 22, 2015
  9. 5/5 shallow: remove unused #include "sigchain.h"Tobias Klauser, Oct 22, 2015
  10. Junio C HamanoOct 22, 2015
  11. Michael HaggertyOct 26, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.