Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 24, 2016, 07:11 UTC
- Message-ID
- <xmqqk2gb8q81.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160722224739.GA22961@whir>
Eric Wong <e@80x24.org> writes:
Show 11 quoted lines
> Users have mistakenly copied "From " lines into commit messages > in the past, and will certainly make the same mistakes in the > future. Since not everyone uses mboxrd, yet, we should at least > prevent miss-split mails by always escaping "From " lines based > on the check used by mailsplit. > > mailsplit will not perform unescaping by default, yet, as it > could cause further invocations of format-patch from old > versions of git to generate bad output. Propagating the mboxo > escaping is preferable to miss-split patches. Unescaping may > still be performed via "--mboxrd".
As a tool to produce mbox file, quoting like this in format-patch output may make sense, I would think, but shouldn't send-email undo this when sending individual patches?