Re: [PATCH] fast-import: properly fanout notes when tree is imported

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 20, 2016, 19:34 UTC
Message-ID: <xmqqk2aujsyb.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161219021212.15978-1-mh@glandium.org>

Mike Hommey <mh@glandium.org> writes:

Show 7 quoted lines

> In typical uses of fast-import, trees are inherited from a parent
> commit. In that case, the tree_entry for the branch looks like:
> ...
> +# Create another notes tree from the one above
> +cat >>input <<INPUT_END
> +...
> +M 040000 $(git log --no-walk --format=%T refs/notes/many_notes)

There is a trailing SP that cannot be seen by anybody.

Don't do this. It makes it very easy to miss what is going on and wastes reviewers' time.

Protect it by doing something like:

	sed -e 's/Z$//' >>input <<INPUT_END
	...
	M 040000 $(git log --no-walk --format=%T refs/notes/many_notes) Z

Thanks.