Re: [PATCH v2 0/2] Fix bugs in rev-parse's output when run in a subdirectory

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2017, 18:59 UTC
Message-ID: <xmqqk28xlvmb.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <cover.1486740772.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

Show 16 quoted lines

> Johannes Schindelin (1):
>   rev-parse: fix several options when running in a subdirectory
>
> Michael Rappazzo (1):
>   rev-parse tests: add tests executed from a subdirectory
>
>  builtin/rev-parse.c      | 15 +++++++++++----
>  t/t1500-rev-parse.sh     | 28 ++++++++++++++++++++++++++++
>  t/t1700-split-index.sh   | 17 +++++++++++++++++
>  t/t2027-worktree-list.sh | 10 +++++++++-
>  4 files changed, 65 insertions(+), 5 deletions(-)
>
>
> base-commit: 6e3a7b3398559305c7a239a42e447c21a8f39ff8
> Published-As: https://github.com/dscho/git/releases/tag/git-path-in-subdir-v2
> Fetch-It-Via: git fetch https://github.com/dscho/git git-path-in-subdir-v2

Will queue as js/git-path-in-subdir topic forked at 2.12-rc0.

I still think the log message in 2/2 is making a mountain out of molehill and showing a skewed perception on pros-and-cons in a design decision, but I won't repeat my review. I saw a few correctness issues and pointed them out on the patches.