Re: [PATCH v1] adding word_regex for go language
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 20, 2017, 20:39 UTC
- Message-ID
- <xmqqk27jvg28.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170320193555.6656-1-souravcristiano502@gmail.com>
sourav mondal <souravcristiano502@gmail.com> writes:
> Subject: Re: [PATCH v1] adding word_regex for go language
Perhaps clarify the title with what area this change affects, e.g.
Subject: userdiff.c: patterns for "go" language
cf. Documentation/SubmittingPatches.
> Go programming language is one of the promissing language now. Adding built-in driver for the same. This patch contains word_regex for go. As the language specification this has alpha-numeric and under-score for identifiers. It covers all types of number system decimal, octal, hexadecimal. Also can specify signed or usigned number by using "u or U", long number by using "l or L" and exponent term by using "e or E". The following lines cover all types of operator ex. arithmatic, logical, bitwise, assignment etc..
Wrap long lines. Also unless there is a good reason not to, we tend to write our log messsage in imperative mood, as if you are giving orders to the codebase to "be like so", or giving orders to a patch monkey to "make the code like so".
Show 26 quoted lines
>
> Signed-off-by: sourav mondal <souravcristiano502@gmail.com>
> ---
>
> I'm working on go language patterns and will send it soon.
> thanks & regards
> sourav
>
> userdiff.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/userdiff.c b/userdiff.c
> index 2f8e078..99f5539 100644
> --- a/userdiff.c
> +++ b/userdiff.c
> @@ -148,6 +148,13 @@ PATTERNS("csharp",
> "[a-zA-Z_][a-zA-Z0-9_]*"
> "|[-+0-9.e]+[fFlL]?|0[xXbB]?[0-9a-fA-F]+[lL]?"
> "|[-+*/<>%&^|=!]=|--|\\+\\+|<<=?|>>=?|&&|\\|\\||::|->"),
> +PATTERNS("go",
> + /* word_regex */
> + "[a-zA-Z_][a-zA-Z0-9]*"/* identifiers */
> + "|[0-9eE]+[lL]?[uU]?|0[xX]?[0-9a-fA-F]+[uU]?[lL]?" /* numbers */
> + "|[-+*/%<>&|!^=]="/* operators */
> + "|--|\\+\\+|&&|<<=|>>=|\\|\\|"
> +),PATTERNS() takes three arguments, the name of the pattern, pattern and word_regex.
Please do not send an incomplete patch that does not even compile without marking as such (i.e. request for help or early comments from those who are willing to help even on an incomplete work).
Thanks.