git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: --indent-heuristic is no longer experimental

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 1, 2017, 06:14 UTC
Message-ID
<xmqqk1zattj7.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<xmqq1sljzt2i.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 15 quoted lines
> Carlos Martín Nieto <cmn@dwim.me> writes:
>
>> This heuristic has been the default since 2.14 so we should not confuse our
>> users by saying that it's experimental and off by default.
>>
>> Signed-off-by: Carlos Martín Nieto <cmn@dwim.me>
>> ---
>>  Documentation/diff-heuristic-options.txt | 5 -----
>>  Documentation/diff-options.txt           | 7 ++++++-
>>  2 files changed, 6 insertions(+), 6 deletions(-)
>>  delete mode 100644 Documentation/diff-heuristic-options.txt
>
> I suspect that this patch is incomplete.  The build procedure barfs
> and dies while making git-annotate.html, claiming that it wants to
> find diff-heuristic-options.txt that no longer exists.

The fix is obvious once you have time to sip your tea and look at the output from "git grep" ;-)

Subject: [PATCH] SQUASH???
---
 Documentation/git-annotate.txt | 1 -
 Documentation/git-blame.txt    | 2 --
 2 files changed, 3 deletions(-)
diff --git a/Documentation/git-annotate.txt b/Documentation/git-annotate.txt
index 94be4b85e0..05fd482b74 100644
--- a/Documentation/git-annotate.txt
+++ b/Documentation/git-annotate.txt
@@ -23,7 +23,6 @@ familiar command name for people coming from other SCM systems.
 OPTIONS
 -------
 include::blame-options.txt[]
-include::diff-heuristic-options.txt[]
 
 SEE ALSO
 --------
diff --git a/Documentation/git-blame.txt b/Documentation/git-blame.txt
index fdc3aea30a..16323eb80e 100644
--- a/Documentation/git-blame.txt
+++ b/Documentation/git-blame.txt
@@ -89,8 +89,6 @@ include::blame-options.txt[]
 	abbreviated object name, use <n>+1 digits. Note that 1 column
 	is used for a caret to mark the boundary commit.
 
-include::diff-heuristic-options.txt[]
-
 
 THE PORCELAIN FORMAT
 --------------------
-- 
2.15.0-206-g5fb43f7f39
Previous: Junio C Hamano
Message 5 of 5 in “diff: --indent-heuristic is no longer experimental”
  1. diff: --indent-heuristic is no longer experimentalCarlos Martín Nieto, Oct 29, 2017
  2. Stefan BellerOct 30, 2017
  3. Junio C HamanoOct 31, 2017
  4. Junio C HamanoOct 31, 2017
  5. Junio C HamanoNov 1, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.