Re: [ANNOUNCE] Git v2.16.0-rc1

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 10, 2018, 20:09 UTC
Message-ID: <xmqqk1wp1nno.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <nycvar.QRO.7.76.6.1801101838360.31@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> No, the only thing that changed was the introduction of Git::Packet (and
> t0021/*.perl uses that). And that Perl module is not yet installed.

Ahh, that is the difference among other users of split(/:/, $ENV{GITPERLLIB}). Scripts other than 0021 may be using installed ones and using the wrong separator does not affect them.

> Granted, we tested incorrect versions of those modules, but this late in
> the -rc phase, I would prefer to be cautious. People might be relying on
> the current bug.

People meaning those who run "make test"?

In any case, the patch to 0021 as posted sounds like the most conservative thing to do at this point, even though we would definitely want to revisit it and clean it up after the release. As long as the reason why only 0021 wants the special case while others are OK is understood, I am OK with the patch ;-)

Thanks.