Re: [PATCH] graph.c: log.showRootMark to indicate root commits

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 2, 2018, 17:57 UTC
Message-ID: <xmqqk1tpze1x.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <0102016283000c69-b09d1499-8a50-45a7-9f41-01be648398bc-000000@eu-west-1.amazonses.com>

Lyubomyr Shaydariv <lsh.dev@ukr.net> writes:

Show 8 quoted lines

> When log.showRootMark is set, root commits are marked with
> the at sign (@).
>
> When log.showRootMark is not set, root commits are marked with
> the asterisk sign (*). This is the default behavior.
>
> Signed-off-by: Lyubomyr Shaydariv <lsh.dev@ukr.net>
> ---

So the idea is when you have a history like this:

    R1--A---B
              \
    R2--C---D---M

to show "git log --oneline --graph D B" like

because you cannot tell that between R1 and D there is no parent-child relationship otherwise?

One downside of that approach is that it is not clear how this feature should interact with --left-right. I do not think there is a clean way to do that, unless you come up with a pair of symbols, not just a single '@'.

Another way to show that there is no parent-child relationship between R1 and D is to show it like this instead:

and that would work well with --left-right automatically (as you would just do the same thing as you would to a normal asterisk).