Re: [PATCH v1] fsmonitor: fix incorrect buffer size when printing version number

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 16, 2018, 01:00 UTC
Message-ID: <xmqqk1t8ynh6.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <2b6b2a54-8349-ea28-f752-4d752c798d5a@gmail.com>

Ben Peart <peartben@gmail.com> writes:

Show 13 quoted lines

> On 4/10/2018 4:17 PM, Eric Sunshine wrote:
>> On Tue, Apr 10, 2018 at 2:43 PM, Ben Peart <Ben.Peart@microsoft.com> wrote:
>>> This is a trivial bug fix for passing the incorrect size to snprintf() when
>>> outputing the version.  It should be passing the size of the destination buffer
>>
>> s/outputing/outputting/
>>
>>> rather than the size of the value being printed.
>>>
>>> Signed-off-by: Ben Peart <benpeart@microsoft.com>
>
> Junio, do you want a re-roll of this simple fix or can you fix the
> spelling of the commit message?

I think I already have that typofix in what is queued.

If there is anything more, I'd prefer to replace with a reroll ;-)

Thanks.